-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPI driver for samg family #680
Conversation
5871502
to
633e2d0
Compare
It pains me to admit that I've failed to understand the GPIO connect system implemented here, and not for lack of trying. As I recall, the method of leaving some pins unconnected in the STM32 drivers is to pass, e.g. |
No, you just don't pass anything. The template arguments have a variable length for this purpose. The STM32 connector just returns
That's fine, you haven't failed at all. This is also a valid way to implement it. I remember something about the Flexcom getting in the way of the GpioUnused API, so I guess that's why the SAM port uses a different way? |
Interesting. I have been doing
You're probably right; though I certainly don't know. It all feels overly complex to me, and I definitely feel like I'm poking at something I only vaguely understand. However I don't want to spend days/weeks figuring it out, and this seems to work, so I'm prepared to push on :). |
633e2d0
to
03ce931
Compare
03ce931
to
f4d5d6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Thank you for maintaining this! You have done all the hard parts :) |
Currently based off feature/samg-usb, on the assumption those will land in develop before this.